Conversation
3 tasks
Member
|
we also need to check the impact it might have on capabilities which might evaluate this and expose it to the clients |
ce1bed4 to
f4875d7
Compare
PVince81
approved these changes
Feb 17, 2022
Member
PVince81
left a comment
There was a problem hiding this comment.
👍 looks fine, please verify with a client
artonge
reviewed
Feb 17, 2022
f4875d7 to
e2d533c
Compare
Member
|
Fixes #30161 |
Member
|
conflicts with #31116 |
Member
|
1 task
Member
|
Member
|
I've renamed the config switch and prefixed with "sharing." like other similar configs in config.php also added to config.sample.php conflict still unresolved |
PVince81
reviewed
Mar 3, 2022
b029f70 to
c903fb4
Compare
Member
|
alright, so the tests still need adjusting: OCA\Settings\Tests\Settings\Admin\SharingTest |
c903fb4 to
78082e0
Compare
Pytal
reviewed
Mar 10, 2022
artonge
approved these changes
Mar 16, 2022
Merged
708c9b3 to
654587e
Compare
654587e to
0fb60d7
Compare
Member
Author
|
/compile amend / |
0fb60d7 to
9430927
Compare
Contributor
|
/rebase |
9430927 to
ab74fe3
Compare
Contributor
|
tests are failing |
Merged
ab74fe3 to
c35938e
Compare
Pytal
approved these changes
Apr 5, 2022
Member
|
/compile amend / |
Signed-off-by: Carl Schwan <[email protected]> Co-authored-by: Vincent Petry <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
c35938e to
a29251e
Compare
Member
|
tests unrelated |
Member
|
@CarlSchwan please update the backports #31194 (comment) |
Merged
come-nc
reviewed
Sep 1, 2022
Comment on lines
+133
to
+134
| <input type="checkbox" name="shareapi_default_expire_date" id="shareapiDefaultExpireDate" class="checkbox" value="1" <?php if ($_['shareDefaultExpireDateSet'] === 'yes') { print_unescaped('checked="checked"'); } ?> /> | ||
|
|
Contributor
There was a problem hiding this comment.
Duplicate checkbox breaks the UI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Todos:
Signed-off-by: Carl Schwan [email protected]