move root mount setup to mountproviders#31266
Conversation
c0732ab to
17e2bdd
Compare
Signed-off-by: Robin Appelman <[email protected]>
17e2bdd to
8b7c844
Compare
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
4738a20 to
b0ce876
Compare
…torage Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
…g part files Signed-off-by: Robin Appelman <[email protected]>
a4387f7 to
ec15020
Compare
|
Added ci setup with objectstore (multibucket) as root storage and fixed some failures when running with objectstore |
CarlSchwan
left a comment
There was a problem hiding this comment.
Looks good 👍 and tests are happy
| @@ -0,0 +1,70 @@ | |||
| name: S3 primary storage | |||
There was a problem hiding this comment.
is this backportable separately?
PVince81
left a comment
There was a problem hiding this comment.
Code looks fine 👍
It does seem to also contain changes that perhaps could be extracted to separate PRs to make them backportable if they solve bigger issues ?
| // the entire operation will be safe | ||
|
|
||
| try { | ||
| $this->acquireLock(ILockingProvider::LOCK_EXCLUSIVE); |
There was a problem hiding this comment.
is this directly related to this PR or is this a fix that we could use separately ?
| @@ -0,0 +1,70 @@ | |||
| name: S3 primary storage | |||
There was a problem hiding this comment.
is this backportable separately?
|
I'll look into backporting the primary storage ci+fixes |
thanks! |
Removes special casing for the root storage from the filesystem setup logic
Requires:
Part of #31265