Fixes the undefined index error with the DAV property getlastmodified#31632
Merged
artonge merged 4 commits intonextcloud:masterfrom Mar 29, 2022
Merged
Fixes the undefined index error with the DAV property getlastmodified#31632artonge merged 4 commits intonextcloud:masterfrom
artonge merged 4 commits intonextcloud:masterfrom
Conversation
Signed-off-by: Max Kunzelmann <[email protected]>
Member
|
Signed-off-by: Max Kunzelmann <[email protected]>
Contributor
Author
|
Somehow I missed that typo yesterday night. Now it should get the proper modified time. |
miaulalala
approved these changes
Mar 21, 2022
PVince81
reviewed
Mar 22, 2022
Maaxxs
commented
Mar 23, 2022
…ist. Signed-off-by: Max Kunzelmann <[email protected]>
artonge
approved these changes
Mar 24, 2022
Merged
Signed-off-by: Max Kunzelmann <[email protected]>
43b21aa to
2952c7d
Compare
artonge
approved these changes
Mar 29, 2022
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
Contributor
|
Thanks for the fix @Maaxxs ! |
Merged
Member
|
Should this be backported? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the undefined index {DAV:}getlastmodified error, which can occur in the
DAV.phpfile.The return value in the else clause is false if neither
getetagnorgetlastmodifiedis set. At least, I would argue that it should return false because false is returned if there is no response ($response === false), and in the exceptions, too.It resolves some errors from issue #15363.