Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Rename setting 'sendEventRemindersToSharedGroupMembers' -> 'sendEventRemindersToSharedUsers'.#31660

Merged
szaimen merged 1 commit intonextcloud:masterfrom
dzatoah:pr/rename-sendEventRemindersToSharedGroupMembers-to-sendEventRemindersToSharedUsers
May 5, 2023
Merged

Rename setting 'sendEventRemindersToSharedGroupMembers' -> 'sendEventRemindersToSharedUsers'.#31660
szaimen merged 1 commit intonextcloud:masterfrom
dzatoah:pr/rename-sendEventRemindersToSharedGroupMembers-to-sendEventRemindersToSharedUsers

Conversation

@dzatoah
Copy link
Contributor

@dzatoah dzatoah commented Mar 22, 2022

@tcitworld #31337 (comment):

Of course I forgot to say we should rename sendEventRemindersToSharedGroupMembers to sendEventRemindersToSharedUsers, as the share can be done with groups as well as direct users.

@dzatoah dzatoah mentioned this pull request Mar 22, 2022
Merged
@dzatoah
Copy link
Contributor Author

dzatoah commented Mar 22, 2022

In which Nextcloud version will this feature come later?

@ChristophWurst
Copy link
Member

ChristophWurst commented Mar 22, 2022

24

@dzatoah dzatoah force-pushed the pr/rename-sendEventRemindersToSharedGroupMembers-to-sendEventRemindersToSharedUsers branch from 40f3bc4 to cc8efc8 Compare March 23, 2022 10:48
@blizzz blizzz added this to the Nextcloud 25 milestone Apr 21, 2022
This was referenced Aug 12, 2022
Merged
Merged
This was referenced Aug 24, 2022
Merged
Merged
This was referenced Sep 6, 2022
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
Merged
This was referenced Sep 20, 2022
Closed
Merged
@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 22, 2022
@dzatoah dzatoah mentioned this pull request Oct 10, 2022
Open
9 tasks
@blizzz blizzz mentioned this pull request Feb 1, 2023
Merged
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
Merged
@blizzz blizzz mentioned this pull request Mar 7, 2023
Merged
@blizzz blizzz modified the milestones: Nextcloud 26, Nextcloud 27 Mar 9, 2023
@szaimen
Copy link
Contributor

szaimen commented Apr 17, 2023

Hi @dzatoah can you please fix the conflicts so that we can merge this? Thanks in advance! :)

@szaimen szaimen added the 2. developing Work in progress label Apr 17, 2023
@skjnldsv skjnldsv mentioned this pull request May 3, 2023
Merged
@dzatoah dzatoah closed this May 4, 2023
@dzatoah dzatoah force-pushed the pr/rename-sendEventRemindersToSharedGroupMembers-to-sendEventRemindersToSharedUsers branch from cc8efc8 to 1a00d99 Compare May 4, 2023 11:03
@dzatoah
Rename setting 'sendEventRemindersToSharedGroupMembers' to 'sendEvent…
56f36b9 
…RemindersToSharedUsers'.

Signed-off-by: Daniel Teichmann <[email protected]>
@szaimen szaimen reopened this May 4, 2023
@dzatoah
Copy link
Contributor Author

dzatoah commented May 4, 2023

Thanks, @szaimen. I was confused af for a moment there...

@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels May 4, 2023
@szaimen szaimen enabled auto-merge May 4, 2023 13:28
@szaimen szaimen merged commit a1ed1db into nextcloud:master May 5, 2023
@ChristophWurst
Copy link
Member

ChristophWurst commented May 5, 2023

@dzatoah @szaimen what's the upgrade path? If this went into 24 it would be fine but now there is a good chance there are instances with a setting for sendEventRemindersToSharedGroupMembers. We have to migrate the old setting over to the new name.

@szaimen
Copy link
Contributor

szaimen commented May 5, 2023

@dzatoah would you be up for creating the migration from the old to the new setting? :)

@dzatoah
Copy link
Contributor Author

dzatoah commented May 5, 2023

I'm sorry, but I have to decline.

@szaimen
Copy link
Contributor

szaimen commented May 5, 2023

I see.

So what then @ChristophWurst? Revert?

@dzatoah
Copy link
Contributor Author

dzatoah commented May 5, 2023

How would you estimate the effort? Is this doable for a Nextcloud newbie?

@ChristophWurst
Copy link
Member

ChristophWurst commented May 5, 2023

This could be done with a repair step that reads any old value and write it under the new name. Repair steps look like this: https://github.com/nextcloud/server/blob/master/lib/private/Repair/OldGroupMembershipShares.php.

@ChristophWurst
Copy link
Member

ChristophWurst commented May 5, 2023

The repair step would belong to the dav app, so maybe https://github.com/nextcloud/server/blob/master/apps/dav/lib/Migration/RemoveObjectProperties.php is better example. The step is then registered in

server/apps/dav/appinfo/info.xml

Lines 30 to 43 in a1ed1db

<repair-steps>
<post-migration>
<step>OCA\DAV\Migration\FixBirthdayCalendarComponent</step>
<step>OCA\DAV\Migration\RegenerateBirthdayCalendars</step>
<step>OCA\DAV\Migration\CalDAVRemoveEmptyValue</step>
<step>OCA\DAV\Migration\BuildCalendarSearchIndex</step>
<step>OCA\DAV\Migration\BuildSocialSearchIndex</step>
<step>OCA\DAV\Migration\RefreshWebcalJobRegistrar</step>
<step>OCA\DAV\Migration\RegisterBuildReminderIndexBackgroundJob</step>
<step>OCA\DAV\Migration\RemoveOrphanEventsAndContacts</step>
<step>OCA\DAV\Migration\RemoveClassifiedEventActivity</step>
<step>OCA\DAV\Migration\RemoveDeletedUsersCalendarSubscriptions</step>
<step>OCA\DAV\Migration\RemoveObjectProperties</step>
</post-migration>

This was referenced May 9, 2023
Closed
Merged
@ChristophWurst
Copy link
Member

ChristophWurst commented May 10, 2023

@szaimen please revert this change

@szaimen szaimen mentioned this pull request May 10, 2023
Closed
@szaimen
Copy link
Contributor

szaimen commented May 10, 2023

Done in #38177

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@tcitworld tcitworld tcitworld approved these changes

@miaulalala miaulalala Awaiting requested review from miaulalala

Assignees

No one assigned

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

Nextcloud 27

Development

Successfully merging this pull request may close these issues.

5 participants

@dzatoah @ChristophWurst @szaimen @tcitworld @blizzz