Conversation
07b953d to
e70db40
Compare
tcitworld
reviewed
Mar 24, 2022
Merged
699fc5a to
8842632
Compare
Member
Author
|
@tcitworld I've tried the way suggested in #30963 (comment) and it seems to have the same results but adds more code than the CardDavBackend way, so unless there is a notable benefit I'll stick with the current CardDavBackend way as it's cleaner and helps abstract away complexity |
8c81905 to
d5743ff
Compare
come-nc
reviewed
Mar 29, 2022
2ae95e0 to
7145d27
Compare
come-nc
requested changes
Mar 30, 2022
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
7145d27 to
53c9edc
Compare
come-nc
approved these changes
Mar 30, 2022
Merged
Signed-off-by: Christopher Ng <[email protected]>
Merged
PVince81
reviewed
Apr 7, 2022
PVince81
reviewed
Apr 7, 2022
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To Do
Most of the 42k added lines are base64 encoded images contained in the *.vcf files for tests