Merged
Conversation
Member
CarlSchwan
commented
May 25, 2022
- Update jest snapshot
- Fix importing 3rdparty vue components
- Disable temporarely tests using nextcloud-vue/Button
PVince81
reviewed
May 25, 2022
PVince81
reviewed
May 25, 2022
277431d to
122a3fd
Compare
Member
|
Looks like the new file needs to be added to tests to satisfy Drone checkers: |
- Update jest snapshot - Fix importing 3rdparty vue components - Disable temporarely tests using nextcloud-vue/Button Signed-off-by: Carl Schwan <[email protected]>
PVince81
reviewed
May 30, 2022
| expect(sendEventRemindersPush).toBeChecked() | ||
|
|
||
| /* | ||
| FIXME userEvent.click is broken with nextcloud-vue/Button |
PVince81
reviewed
May 30, 2022
|
|
||
| // TODO: find a way to consolidate this in one place, with webpack.common.js | ||
| const ignorePatterns = [ | ||
| 'vue-material-design-icons', |
Member
There was a problem hiding this comment.
hope we can eventually centralize those as this is copied from the talk repo
and also wondering how many we still need now that IE / old Edge support is out
artonge
approved these changes
May 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.