Merged
Conversation
c857fa5 to
62681dd
Compare
blizzz
reviewed
Jun 29, 2022
Member
blizzz
left a comment
There was a problem hiding this comment.
More return type hints. Ok to have the concrete implementation in the public namespace in this case.
| /** | ||
| * @since 25.0.0 | ||
| */ | ||
| public function remove($key) { |
Member
There was a problem hiding this comment.
Suggested change
| public function remove($key) { | |
| public function remove($key): bool { |
| * @inheritdoc | ||
| * @since 25.0.0 | ||
| */ | ||
| public function clear($prefix = '') { |
Member
There was a problem hiding this comment.
Suggested change
| public function clear($prefix = '') { | |
| public function clear($prefix = ''): bool { |
| * @return T[] | ||
| * @since 25.0.0 | ||
| */ | ||
| public function getData() { |
Member
There was a problem hiding this comment.
Suggested change
| public function getData() { | |
| public function getData(): array { |
| } | ||
|
|
||
|
|
||
| private function garbageCollect() { |
Member
There was a problem hiding this comment.
Suggested change
| private function garbageCollect() { | |
| private function garbageCollect(): void { |
skjnldsv
approved these changes
Jun 30, 2022
62681dd to
f905059
Compare
This is an helpful helper that should be used in more place than just server and this is already the case with groupfodlers, deck, user_oidc and more using it, so let's make it public Signed-off-by: Carl Schwan <[email protected]>
f905059 to
d5c23db
Compare
ArtificialOwl
approved these changes
Jul 14, 2022
Merged
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an helpful helper that should be used in more place than just
server and this is already the case with groupfodlers, deck, user_oidc
and more using it, so let's make it public
how to port your app