Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix typos in lib/public subdirectory#33381

Merged
skjnldsv merged 1 commit intonextcloud:masterfrom
luzpaz:fix/lib-public-typos
May 11, 2023
Merged

Fix typos in lib/public subdirectory#33381
skjnldsv merged 1 commit intonextcloud:masterfrom
luzpaz:fix/lib-public-typos

Conversation

@luzpaz
Copy link
Contributor

@luzpaz luzpaz commented Jul 27, 2022

Found via codespell -q 3 -S l10n -L jus ./lib/private

Signed-off-by: luz paz [email protected]

PVince81
PVince81 approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks fine

@PVince81 PVince81 added 3. to review Waiting for reviews technical debt labels Jul 27, 2022
@PVince81 PVince81 added this to the Nextcloud 25 milestone Jul 27, 2022
come-nc
come-nc requested changes Jul 28, 2022
View reviewed changes
@luzpaz luzpaz force-pushed the fix/lib-public-typos branch from f488ef6 to 4993285 Compare July 28, 2022 10:21
@luzpaz
Copy link
Contributor Author

luzpaz commented Jul 28, 2022

Squashed. Shall I also rebase or not necessary?

@come-nc
Copy link
Contributor

come-nc commented Jul 28, 2022

Squashed. Shall I also rebase or not necessary?

I do not think a rebase is needed, but the DCO bot is somehow unhappy, can you look into it?

@luzpaz luzpaz force-pushed the fix/lib-public-typos branch from 4993285 to 3543afa Compare July 28, 2022 12:18
@luzpaz
Copy link
Contributor Author

luzpaz commented Jul 28, 2022

Not sure why.

@szaimen
Copy link
Contributor

szaimen commented Jul 28, 2022 •
edited
Loading

I think it expects a different mail but this is not a problem and we can just set it to pass, afaics.

Edit: done

This was referenced Aug 12, 2022
Merged
Merged
This was referenced Aug 24, 2022
Merged
Merged
This was referenced Sep 6, 2022
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
Merged
This was referenced Sep 20, 2022
Closed
Merged
@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 22, 2022
@blizzz blizzz mentioned this pull request Feb 1, 2023
Merged
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
Merged
@blizzz blizzz mentioned this pull request Mar 7, 2023
Merged
@blizzz blizzz removed this from the Nextcloud 26 milestone Mar 9, 2023
@blizzz blizzz added this to the Nextcloud 27 milestone Mar 9, 2023
@szaimen szaimen force-pushed the fix/lib-public-typos branch from 3543afa to d10264f Compare April 17, 2023 13:53
@szaimen szaimen enabled auto-merge April 17, 2023 13:53
This was referenced May 3, 2023
Merged
Closed
Merged
@skjnldsv
Copy link
Member

skjnldsv commented May 10, 2023

Please fix conflict and we can merge

@skjnldsv skjnldsv modified the milestones: Nextcloud 27, Nextcloud 28 May 10, 2023
@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels May 10, 2023
@skjnldsv skjnldsv disabled auto-merge May 10, 2023 09:50
@szaimen @come-nc
Fix typos in lib/public subdirectory
d55a7c6 
Found via `codespell -q 3 -S l10n -L jus ./lib/public`

Signed-off-by: luz paz <[email protected]>

Update lib/public/Accounts/IAccount.php

Signed-off-by: luz paz <[email protected]>

Signed-off-by: Simon L <[email protected]>
Co-Authored-By: Côme Chilliet <[email protected]>
@szaimen szaimen force-pushed the fix/lib-public-typos branch from d10264f to d55a7c6 Compare May 10, 2023 09:57
@szaimen szaimen enabled auto-merge May 10, 2023 09:59
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels May 11, 2023
@skjnldsv skjnldsv modified the milestones: Nextcloud 28, Nextcloud 27 May 11, 2023
@skjnldsv skjnldsv disabled auto-merge May 11, 2023 08:26
@skjnldsv skjnldsv merged commit 979f403 into nextcloud:master May 11, 2023
@luzpaz luzpaz deleted the fix/lib-public-typos branch May 13, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PVince81 PVince81 PVince81 approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@come-nc come-nc come-nc approved these changes

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish technical debt

Projects

None yet

Milestone

Nextcloud 27

Development

Successfully merging this pull request may close these issues.

6 participants

@luzpaz @come-nc @szaimen @skjnldsv @PVince81 @blizzz