Conversation
9 tasks
Contributor
|
the multiselect looks strange but I guess it will be improved with the next beta release of vue 7.0, correct? |
Member
|
Let's get this in after #34044 |
Merged
- Add label instead of placeholder for accessibility - Port to new vue components Signed-off-by: Carl Schwan <[email protected]>
3d0f7eb to
103ba53
Compare
Pytal
approved these changes
Sep 15, 2022
Co-authored-by: Pytal <[email protected]> Signed-off-by: Carl Schwan <[email protected]>
Member
Author
|
/compile amend / |
Co-authored-by: Pytal <[email protected]> Signed-off-by: Carl Schwan <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
f28da3d to
7619ca2
Compare
Member
|
Contributor
Maybe something wrong with resetting the focus or something? Also, can we remove the custom multiselect styling and check if it improves the look? |
Contributor
|
@CarlSchwan what is missing here? |
Member
|
@Pytal please take over when the time is right as it touches accessibility |
Contributor
|
Now that we updated nextcloud/vue miltiple times in the meantime, maybe even a rebase already makes it work... |
Closed
Contributor
|
I rebase this and pushed the changes to #35898 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.