Set focus to input field for login form#34050
Merged
Conversation
CarlSchwan
approved these changes
Sep 13, 2022
raimund-schluessler
requested changes
Sep 13, 2022
raimund-schluessler
approved these changes
Sep 13, 2022
Contributor
Author
|
Carl suggested to use the Pull Request for component library (to forward autofocus attribute): nextcloud-libraries/nextcloud-vue#3245 I suggest to still merge this pull request and migrate to autofocus attribute as follow up. |
70426aa to
6e60e26
Compare
Member
|
conflict :-/ |
9 tasks
6e60e26 to
c93521d
Compare
Contributor
Author
|
Recompiled to fix the conflicts 👻 |
Member
|
Works from client/UI side 👍 |
Member
|
@kesselb recompiling is not enough. You need to rebase first... (I made the same mistake recently...) |
Fix: - TypeError: this.$refs.user.focus is not a function - TypeError: this.$refs.password.focus is not a function Signed-off-by: Daniel Kesselberg <[email protected]>
c93521d to
3837019
Compare
Contributor
Author
|
Thanks for heads up 👍 #33512 changed core-common.js so another rebase and recompile is necessary ✌️ Should be good now. Let's hope nothing else is merged in the meantime 😎 |
Merged
Contributor
|
@skjnldsv can we revert this after https://github.com/nextcloud/nextcloud-vue/releases/tag/v7.1.0-beta.1? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix:
TypeError: this.$refs.user.focus is not a function
TypeError: this.$refs.password.focus is not a function
Fixes #34077