Do not store generated mysql password if it was not used#34152
Merged
Do not store generated mysql password if it was not used#34152
Conversation
Signed-off-by: Julius Härtl <[email protected]>
nickvergessen
approved these changes
Sep 20, 2022
CarlSchwan
approved these changes
Sep 20, 2022
Member
|
Does this fix #34123? |
I suppose so, in NC24 I have commented out the line To bypass the reset of the password, but it seems the fix from this PR would fix it as well. Maybe if someone can confirm? And maybe this could be backported to NC24 as well so I can avoid patching the source, and @Ma27 who created #34123 as well. Since #30130, it is causing an issue, as
|
9 tasks
Contributor
|
/backport to stable25 |
Contributor
|
/backport to stable24 |
This was referenced Jan 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure that we do not store and use the generated password if it wasn't used for user creation in cases where there is a dbpass already preconfigured
https://github.com/nextcloud/server/blob/bugfix/noid/db-password-install/lib/private/Setup/MySQL.php#L158-L159