Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Changed mapping to font#34419

Merged
susnux merged 2 commits intonextcloud:masterfrom
dos-2:fix-icons
Aug 3, 2023
Merged

Changed mapping to font#34419
susnux merged 2 commits intonextcloud:masterfrom
dos-2:fix-icons

Conversation

@dos-2
Copy link
Contributor

@dos-2 dos-2 commented Oct 4, 2022 •
edited by susnux
Loading

old
Previous code had "application/font-woff": "image"
which caused the error.
new
New code has fixed the mapping.

@szaimen szaimen added the 3. to review Waiting for reviews label Oct 4, 2022
@szaimen szaimen added this to the Nextcloud 26 milestone Oct 4, 2022
@szaimen szaimen requested a review from juliusknorr October 4, 2022 07:06
@tcitworld tcitworld mentioned this pull request Oct 4, 2022
Closed
juliusknorr
juliusknorr requested changes Oct 4, 2022
View reviewed changes
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your pull request.

This should also get adjusted in core/js/mimetypelist.js

In addition it might make sense for other font related mime types as well

@juliusknorr
Copy link
Member

juliusknorr commented Oct 4, 2022

@jancborchardt Maybe you can come up with a nice icon for font files?

@jancborchardt
Copy link
Member

jancborchardt commented Oct 5, 2022

Yes, format-font would be a good icon. (Not in Material Design core apparently, but from https://mdisearch.com/ )

@blizzz blizzz mentioned this pull request Feb 1, 2023
Merged
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
Merged
@blizzz blizzz mentioned this pull request Mar 7, 2023
Merged
@blizzz blizzz modified the milestones: Nextcloud 26, Nextcloud 27 Mar 9, 2023
This was referenced May 3, 2023
Merged
Closed
Merged
@blizzz blizzz mentioned this pull request May 17, 2023
Merged
@blizzz blizzz modified the milestones: Nextcloud 27, Nextcloud 28 May 23, 2023
dos-2 and others added 2 commits August 3, 2023 04:53
@dos-2 @susnux
Changed mapping to font
4c7495f 
* Updated mimetypelist icon mapping

Signed-off-by: Dany1718 <[email protected]>
@susnux
fix: Add icon for font files
2068d78 
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux requested review from a team, Pytal, artonge, juliusknorr and susnux and removed request for a team August 3, 2023 02:59
@susnux
Copy link
Contributor

susnux commented Aug 3, 2023

I rebased the PR and pushed a commit providing the icon @jancborchardt suggested, it looks like this now:

image

@susnux susnux requested a review from nfebe August 3, 2023 03:16
@susnux susnux merged commit 9a7e2b1 into nextcloud:master Aug 3, 2023
@welcome
Copy link

welcome bot commented Aug 3, 2023

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@kesselb
Copy link
Contributor

kesselb commented Aug 3, 2023

The failing CheckerTest looks related

Screenshot from 2023-08-03 21-55-13

@kesselb
Copy link
Contributor

kesselb commented Aug 3, 2023

Fix: #39705

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes

@nfebe nfebe nfebe approved these changes

@artonge artonge Awaiting requested review from artonge artonge is a code owner automatically assigned from nextcloud/server-frontend

@Pytal Pytal Awaiting requested review from Pytal Pytal is a code owner automatically assigned from nextcloud/server-frontend

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

No one assigned

Labels

3. to review Waiting for reviews enhancement feature: files

Projects

None yet

Milestone

Nextcloud 28

Development

Successfully merging this pull request may close these issues.

Icons for font files are incorrect in Files app

8 participants

@dos-2 @juliusknorr @jancborchardt @susnux @kesselb @nfebe @blizzz @szaimen