Make sure to never trigger files hooks on a null path#36893
Merged
Conversation
Contributor
Author
|
|
Thank you so much for the fix. I am really needing this fix because of issues with syncing bigger files. |
9 tasks
Contributor
Author
|
/rebase |
8843759 to
1021d03
Compare
icewind1991
approved these changes
May 2, 2023
Contributor
Author
|
/rebase |
artonge
reviewed
May 2, 2023
1021d03 to
52902ef
Compare
Merged
artonge
approved these changes
May 4, 2023
susnux
approved these changes
May 4, 2023
Contributor
Author
|
/rebase |
|
Apologies for my lack of experience with GitHub and NC development, but will this only be pushed into Nextcloud 27 and not in a 26.0.x patch? |
Contributor
Yes this will first be pushed into Nextcloud 27 and might then be backported to 26.0.x. |
Signed-off-by: Côme Chilliet <[email protected]>
52902ef to
6034cc6
Compare
Member
|
@come-nc OK to be backported? |
Contributor
Author
|
Hum yeah psalm will complain about the backports I think because typing was hell, but let’s try it. |
Contributor
Author
|
/backport to stable26 |
Contributor
Author
|
/backport to stable25 |
This was referenced May 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
strpos()and/orpathinfo(): Passing null to parameter #1 ($haystack) of type string is deprecated #34932Summary
File pre/post operation events should only be triggered for files inside the default view.
For other files a bogus event with a null path was fired, this avoids that.
Checklist