fix(workflowengine): Fix multiple UI issues in workflow engine admin settings#38170
Merged
nickvergessen merged 2 commits intomasterfrom May 10, 2023
Merged
fix(workflowengine): Fix multiple UI issues in workflow engine admin settings#38170nickvergessen merged 2 commits intomasterfrom
nickvergessen merged 2 commits intomasterfrom
Conversation
Member
Author
|
/backport c20fd9f to stable26 |
This comment was marked as resolved.
This comment was marked as resolved.
Antreesy
reviewed
May 10, 2023
Member
Author
Yeah can be fixed by migrating the inputs to NcTextField but I don't feel comfortable doing that skill wise (due to the v-model, etc that's necessary).
Will have a look |
Contributor
Well, NcTextField is 44px high, which is still not enough. But I could take a look afterwards |
Merged
…settings Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
0ff7582 to
0983572
Compare
Member
Author
|
Fixed all the other NcMultiselect components in workflowengine |
Antreesy
approved these changes
May 10, 2023
juliusknorr
approved these changes
May 10, 2023
Merged
1 task
Contributor
|
Thanks Joas for tackling this! As far as I can see is now only one component not migrated yet: |
Member
Author
|
Cool, didn't even check that. I wanted to fix 1 component, ended up fixing a tone, and only 1 is left. That's a great outcome :P |
4 tasks
This was referenced Aug 4, 2024
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Xbutton has no title/aria label and wraps to new lineChecklist