take share by mail into consideration if we calculate the access list#3843
Merged
nickvergessen merged 1 commit intomasterfrom Mar 15, 2017
Merged
take share by mail into consideration if we calculate the access list#3843nickvergessen merged 1 commit intomasterfrom
nickvergessen merged 1 commit intomasterfrom
Conversation
Signed-off-by: Bjoern Schiessle <[email protected]>
Member
|
@schiessle there is #2834 but that has speed issues (because this one actually calculates the correct paths for all users). |
Member
Author
|
Steps to test:
-> before it will fail, with this PR it should work anyone wants to review it... @nickvergessen @rullzer @nextcloud/encryption ? |
rullzer
approved these changes
Mar 15, 2017
nickvergessen
approved these changes
Mar 15, 2017
Member
nickvergessen
left a comment
There was a problem hiding this comment.
Solution looks good and is simple enough for a backport
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
take share by mail into consideration if we calculate the access list to allow people to access encrypted files shared by mail.
cc @rullzer we still use the old API here, am I right that we don't have a similar function for the new share API? I only found, which looks scary https://github.com/nextcloud/server/blob/master/lib/private/Share20/Manager.php#L1194 😉
fix #3751