(occ db:convert-type) Add support for UNIX sockets#39242
Merged
skjnldsv merged 1 commit intonextcloud:masterfrom Sep 4, 2024
Merged
(occ db:convert-type) Add support for UNIX sockets#39242skjnldsv merged 1 commit intonextcloud:masterfrom
skjnldsv merged 1 commit intonextcloud:masterfrom
Conversation
nfebe
reviewed
Jul 14, 2023
nfebe
reviewed
Jul 14, 2023
Contributor
nfebe
left a comment
There was a problem hiding this comment.
Looks okay though I left an inline suggestion. Do you mind using regex instead?
Merged
864c17c to
1ac39e7
Compare
This was referenced Mar 12, 2024
Merged
Merged
Merged
Merged
Member
|
Hey @joshtrichards |
Fixes nextcloud#31998 Adds support to `occ db:convert-type` to support UNIX socket connections via MySQL/MariaDB. Uses same `dbhost` / `hostname` parameter parsing logic (adapted) as used elsewhere (at least the relevant parts) for consistency. Signed-off-by: Josh Richards <[email protected]>
1ac39e7 to
71fff03
Compare
skjnldsv
approved these changes
Aug 16, 2024
Contributor
|
@joshtrichards as you are a member of Nextcloud organization, could you maybe move this into a local branch? Some CI does not work on forks 😔 |
Member
|
Merged, anyway, tests passed locally for me |
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support to
occ db:convert-typeto support UNIX socket connections via MySQL/MariaDB:dbhost/hostnameparameter parsing logic (adapted) as used elsewhere (at least the relevant parts) for consistency.Checklist