[stable27] fix(isLegitimatedForUserId): Setup mountpoints to check file access#41082
Merged
[stable27] fix(isLegitimatedForUserId): Setup mountpoints to check file access#41082
Conversation
| $mountInfos = $this->userMountCache->getMountsForFileId($fileId, $uid); | ||
| foreach ($mountInfos as $mountInfo) { | ||
| $mount = $this->mountManager->getMountFromMountInfo($mountInfo); | ||
| if ($mount && $mount->getStorage() && !empty($mount->getStorage()->getCache()->get($fileId))) { |
Check notice
Code scanning / Psalm
PossiblyNullReference
d64f493 to
e53bc50
Compare
Member
Author
|
Manually tested on stable27. |
icewind1991
approved these changes
Oct 24, 2023
Member
Author
|
/backport to stable26 |
juliusknorr
approved these changes
Oct 25, 2023
This fixes workflows on groupfolders, as it will consider access to files in groupfolders. It also fixes false positives where access to files was limited by other means not taken into account before, e.g. access control. For postDelete events, check for permissions of the parent folder instead, as the file itself no longer exists. Fixes: nextcloud/flow_notifications#71 Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
e53bc50 to
9ed1bbe
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport of #40482
This fixes workflows on groupfolders, as it will consider access to files in groupfolders.
It also fixes false positives where access to files was limited by other means not taken into account before, e.g. access control.
For postDelete events, check for permissions of the parent folder instead, as the file itself no longer exists.
Fixes: nextcloud/flow_notifications#71
Idea taken from #38946