Codestin Search App

ShGKme · 2023-10-31T00:06:27Z

Resolves: [Bug]: open shared folder doesn't work #39565

Summary

A small regression from #35772

This issue does not exist on Nextcloud 28 due to full files to view migration.

How to reproduce

Share "Folder A" with some "User"
Log in as "User"
Open Files
Open "Shared with you"
Click on "Folder A"

Expected behavior:
- it opens the sahred folder
- only "/FolderA" files are requested in "Network"
Actual behavior:
- root files are shown for a second or as the result
- "/" and "/FolderA" twice are requested

Try several times to reproduce. Then more files in root then more chances to reproduce.

bug.mp4

Root of the issue

There is a race condition.

Opening a shared folder makes 2 actions:

server/apps/files_sharing/js/app.js

Lines 260 to 263 in 6bfbb47

    
           fileActions.register('dir', 'Open', OC.PERMISSION_READ, '', function(filename, context) { 
        
           	OCA.Files.App.setActiveView('files', { silent: true }) 
        
           	OCA.Files.App.fileList.changeDirectory(OC.joinPaths(context.$file.attr('data-path'), filename), true, true) 
        
           })

Changing view from "sharingin" to "files" emits files:legacy-navigation:changed

server/apps/files/js/app.js

Lines 223 to 226 in 6bfbb47

    
           setActiveView: function(viewId) { 
        
           	// The Navigation API will handle the final event 
        
           	window._nc_event_bus.emit('files:legacy-navigation:changed', { id: viewId }) 
        
           },

Then the Files view is open on root path / which causes fetching the root files list.

server/apps/files/src/views/Navigation.vue

Lines 233 to 242 in 6bfbb47

    
           		onLegacyNavigationChanged({ id } = { id: 'files' }) { 
        
           			const view = this.Navigation.views.find(view => view.id === id) 
        
           			if (view && view.legacy && view.id !== this.currentView.id) { 
        
           				// Force update the current route as the request comes 
        
           				// from the legacy files app router 
        
           				this.$router.replace({ ...this.$route, params: { view: view.id } }) 
        
           				this.Navigation.setActive(view) 
        
           				this.showView(view) 
        
           			} 
        
           		},

See this.show:

server/apps/files/src/views/Navigation.vue

Lines 214 to 219 in 2aa15a1

    
           				const { dir = '/' } = OC.Util.History.parseUrlQuery() 
        
           				const params = { itemId: view.id, dir } 
        
           				logger.debug('Triggering legacy navigation event', params) 
        
           				window.jQuery(newAppContent).trigger(new window.jQuery.Event('show', params)) 
        
           				window.jQuery(newAppContent).trigger(new window.jQuery.Event('urlChanged', params))

And the handler:

server/apps/files/js/filelist.js

Lines 779 to 788 in 2aa15a1

    
           _onUrlChanged: function(e) { 
        
           	if (e && _.isString(e.dir)) { 
        
           		var currentDir = this.getCurrentDirectory(); 
        
           		// this._currentDirectory is NULL when fileList is first initialised 
        
           		if(this._currentDirectory && currentDir === e.dir) { 
        
           			return; 
        
           		} 
        
           		this.changeDirectory(e.dir, true, true, undefined, true); 
        
           	} 
        
           },

Here is were the first request is made.

Then the initial changeDirectory is called. Which also results in changing directory (to the correct one) and fetching the actual shared directory files list.

🏎️ Here is a race. When the root directory is large, its response may come later so root files are shown instead of the shared folder.

Changing view also triggers a shown event that sets the current directory to / and reloads content. It causes duplicated file requests.

server/apps/files/js/filelist.js

Lines 765 to 774 in 2aa15a1

    
           _onShow: function(e) { 
        
           	OCA.Files.App && OCA.Files.App.updateCurrentFileList(this); 
        
           	if (e.itemId === this.id) { 
        
           		this._setCurrentDir('/', false); 
        
           	} 
        
           	// Only reload if we don't navigate to a different directory 
        
           	if (typeof e.dir === 'undefined' || e.dir === this.getCurrentDirectory()) { 
        
           		this.reload(); 
        
           	} 
        
           },

Before Vue migration, there was a check for this.shown that avoided this behavior.

server/apps/files/js/filelist.js

Lines 761 to 773 in f720d6e

    
           _onShow: function(e) { 
        
           	OCA.Files.App && OCA.Files.App.updateCurrentFileList(this); 
        
           	if (this.shown) { 
        
           		if (e.itemId === this.id) { 
        
           			this._setCurrentDir('/', false); 
        
           		} 
        
           		// Only reload if we don't navigate to a different directory 
        
           		if (typeof e.dir === 'undefined' || e.dir === this.getCurrentDirectory()) { 
        
           			this.reload(); 
        
           		} 
        
           	} 
        
           	this.shown = true; 
        
           },

If I'm not wrong, with migrating navigation to Vue, we can just remove this part. cc @skjnldsv

TODO

Add silent mode support for legacy navigation changed. Actually, the same that was there before migration to Vue.
Remove resetting and reloading on view show

Checklist

Code is properly formatted
Sign-off message is added to all commits
Tests (unit, integration, api and/or acceptance) are included
Screenshots before/after for front-end changes
Documentation (manuals or wiki) has been updated or is not required
Backports requested where applicable (ex: critical bugfixes)

ShGKme · 2023-10-31T00:07:10Z

/backport to stable26

Signed-off-by: Grigorii K. Shartsev <[email protected]>

It is handled by new navigation with Vue Signed-off-by: Grigorii K. Shartsev <[email protected]>

Signed-off-by: Grigorii K. Shartsev <[email protected]>

skjnldsv

Make sense! Nice catch, this legacy router is a pain 🥖

ShGKme · 2023-10-31T12:23:57Z

Want to check one more case with page reload when switching from the shared folder to "All files".

ShGKme · 2023-10-31T12:24:27Z

@skjnldsv Do know any edge cases with legacy navigation/apps here that should be tested?

ShGKme · 2023-10-31T12:57:42Z

Want to check one more case with page reload when switching from the shared folder to "All files".

Unrelated to this issue.

OC.Util.History stores query param as a string in a native history.state. vue-router stores its own state there and crashes found a string there.

ShGKme · 2023-10-31T15:28:58Z

/backport to stable26

ShGKme added bug 3. to review Waiting for reviews feature: files regression labels Oct 31, 2023

ShGKme added this to the Nextcloud 27.1.4 milestone Oct 31, 2023

ShGKme requested review from skjnldsv and sorbaugh October 31, 2023 00:06

ShGKme self-assigned this Oct 31, 2023

ShGKme linked an issue Oct 31, 2023 that may be closed by this pull request

[Bug]: open shared folder doesn't work #39565

Closed

8 tasks

backportbot-nextcloud bot added the backport-request label Oct 31, 2023

ShGKme added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Oct 31, 2023

ShGKme added 3 commits October 31, 2023 01:17

fix(files): add silent mode in legacy navigation

ffda3db

Signed-off-by: Grigorii K. Shartsev <[email protected]>

fix(files): remove resetting and reload curr dir on show

38dd8b3

It is handled by new navigation with Vue Signed-off-by: Grigorii K. Shartsev <[email protected]>

chore(assets): Recompile assets

d439417

Signed-off-by: Grigorii K. Shartsev <[email protected]>

ShGKme force-pushed the fix/39565/race-condition-on-web-files-view branch from 01b4b30 to d439417 Compare October 31, 2023 00:17

skjnldsv approved these changes Oct 31, 2023

View reviewed changes

sorbaugh approved these changes Oct 31, 2023

View reviewed changes

ShGKme added 3. to review Waiting for reviews 2. developing Work in progress and removed 2. developing Work in progress 3. to review Waiting for reviews labels Oct 31, 2023

ShGKme added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 31, 2023

ShGKme merged commit e9189e0 into stable27 Oct 31, 2023

ShGKme deleted the fix/39565/race-condition-on-web-files-view branch October 31, 2023 13:59

ShGKme changed the title ~~fix(files): race condition on web files view change~~ [stable27] fix(files): race condition on web files view change Oct 31, 2023

ShGKme mentioned this pull request Oct 31, 2023

[stable26] fix(files): race condition on web files view change #41224

Merged

blizzz mentioned this pull request Nov 13, 2023

27.1.4 RC1 #41430

Merged

ShGKme mentioned this pull request Nov 14, 2023

[Bug]: open shared folder doesn't work #39565

Closed

8 tasks

skjnldsv removed the backport-request label Jan 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[stable27] fix(files): race condition on web files view change#41206

[stable27] fix(files): race condition on web files view change#41206
ShGKme merged 3 commits intostable27from
fix/39565/race-condition-on-web-files-view

ShGKme commented Oct 31, 2023 •

edited

Loading

Uh oh!

ShGKme commented Oct 31, 2023

Uh oh!

skjnldsv left a comment

Uh oh!

ShGKme commented Oct 31, 2023

Uh oh!

ShGKme commented Oct 31, 2023

Uh oh!

ShGKme commented Oct 31, 2023 •

edited

Loading

Uh oh!

ShGKme commented Oct 31, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	fileActions.register('dir', 'Open', OC.PERMISSION_READ, '', function(filename, context) {
	OCA.Files.App.setActiveView('files', { silent: true })
	OCA.Files.App.fileList.changeDirectory(OC.joinPaths(context.$file.attr('data-path'), filename), true, true)
	})

	setActiveView: function(viewId) {
	// The Navigation API will handle the final event
	window._nc_event_bus.emit('files:legacy-navigation:changed', { id: viewId })
	},

	onLegacyNavigationChanged({ id } = { id: 'files' }) {
	const view = this.Navigation.views.find(view => view.id === id)
	if (view && view.legacy && view.id !== this.currentView.id) {
	// Force update the current route as the request comes
	// from the legacy files app router
	this.$router.replace({ ...this.$route, params: { view: view.id } })
	this.Navigation.setActive(view)
	this.showView(view)
	}
	},

	const { dir = '/' } = OC.Util.History.parseUrlQuery()
	const params = { itemId: view.id, dir }

	logger.debug('Triggering legacy navigation event', params)
	window.jQuery(newAppContent).trigger(new window.jQuery.Event('show', params))
	window.jQuery(newAppContent).trigger(new window.jQuery.Event('urlChanged', params))

	_onUrlChanged: function(e) {
	if (e && _.isString(e.dir)) {
	var currentDir = this.getCurrentDirectory();
	// this._currentDirectory is NULL when fileList is first initialised
	if(this._currentDirectory && currentDir === e.dir) {
	return;
	}
	this.changeDirectory(e.dir, true, true, undefined, true);
	}
	},

	_onShow: function(e) {
	OCA.Files.App && OCA.Files.App.updateCurrentFileList(this);
	if (e.itemId === this.id) {
	this._setCurrentDir('/', false);
	}
	// Only reload if we don't navigate to a different directory
	if (typeof e.dir === 'undefined' \|\| e.dir === this.getCurrentDirectory()) {
	this.reload();
	}
	},

	_onShow: function(e) {
	OCA.Files.App && OCA.Files.App.updateCurrentFileList(this);
	if (this.shown) {
	if (e.itemId === this.id) {
	this._setCurrentDir('/', false);
	}
	// Only reload if we don't navigate to a different directory
	if (typeof e.dir === 'undefined' \|\| e.dir === this.getCurrentDirectory()) {
	this.reload();
	}
	}
	this.shown = true;
	},

Uh oh!

Conversation

ShGKme commented Oct 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

How to reproduce

Root of the issue

TODO

Checklist

Uh oh!

ShGKme commented Oct 31, 2023

Uh oh!

skjnldsv left a comment

Choose a reason for hiding this comment

Uh oh!

ShGKme commented Oct 31, 2023

Uh oh!

ShGKme commented Oct 31, 2023

Uh oh!

ShGKme commented Oct 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ShGKme commented Oct 31, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ShGKme commented Oct 31, 2023 •

edited

Loading

ShGKme commented Oct 31, 2023 •

edited

Loading