Migrate opcache check to new SetupCheck API#41547
Merged
Conversation
47bf97f to
09c67c5
Compare
33 tasks
09c67c5 to
95ea46c
Compare
7ee93fb to
a9c6381
Compare
Base automatically changed from
feat/merge-sqlite-check-to-database-check
to
master
December 11, 2023 14:00
a9c6381 to
114c0eb
Compare
Contributor
Author
|
For the |
Altahrim
reviewed
Dec 13, 2023
4 tasks
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
72b1474 to
e832c14
Compare
Signed-off-by: Côme Chilliet <[email protected]>
e832c14 to
94d0399
Compare
Altahrim
approved these changes
Jan 8, 2024
artonge
approved these changes
Jan 8, 2024
Contributor
artonge
left a comment
There was a problem hiding this comment.
Anything changed beside moving code and adapting tests?
Contributor
Author
|
Failure not related, see #42633 |
Contributor
Author
Yes, level is error or warninig depending on which recommendation is triggered, saw that with Benjamin. |
4 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate opcache check to new SetupCheck API
TODO
<code>tags.Checklist