fix(theming): Adjust dark theme to be accessible adjust cypress tests#41948
Merged
fix(theming): Adjust dark theme to be accessible adjust cypress tests#41948
Conversation
77d86cc to
464b56c
Compare
Pytal
approved these changes
Nov 30, 2023
Also fix warning text color for bright / default theme on blurry background Signed-off-by: Ferdinand Thiessen <[email protected]>
464b56c to
da346aa
Compare
Contributor
Author
|
BTW unrelated but I noticed that the highcontrast themes are not fulfilling WCAG AAA contrast. I think that should be changed? |
Contributor
Author
|
/backport to stable28 |
skjnldsv
approved these changes
Dec 5, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Basically on dark mode all status colors had to be made a bit brighter, on bright mode only the warning color failed the tests for the blurry background (but only a little adjustment was needed).
Checklist