Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Revert "Improve shared status button"#42041

Closed
skjnldsv wants to merge 1 commit intomasterfrom
revert/41453
Closed

Revert "Improve shared status button"#42041
skjnldsv wants to merge 1 commit intomasterfrom
revert/41453

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Dec 5, 2023 •
edited
Loading

This reverts commit c2c5994.

Sorry @marcoambrosini, I cannot approve the previous PR:

  1. using deep selectors is not acceptable to me
  2. you're changing this for all actions, while only the sharing got request
  3. a comment was written by a lead with another lead reaction and got completely ignored

I'll have a look with the design team to make sure we keep the previous issue fixed too

@skjnldsv skjnldsv added this to the Nextcloud 28 milestone Dec 5, 2023
@skjnldsv skjnldsv requested review from a team, emoral435, marcoambrosini, nfebe, sorbaugh and susnux and removed request for a team December 5, 2023 16:40
@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Dec 5, 2023
@skjnldsv
Copy link
Member Author

skjnldsv commented Dec 5, 2023

I'll have a look with the design team to make sure we keep the previous issue fixed too

@blizzz blizzz mentioned this pull request Dec 5, 2023
Merged
5 tasks
@marcoambrosini
Copy link
Member

marcoambrosini commented Dec 5, 2023

Aside from the execution, admittedly poor and rushed, I just want to register that I did this reluctantly and didn't agree much with the set of changes proposed for this button. Nor with how fast they were rushed in without exploring other solutions.
So I thought of this as a temporary hack, while waiting to have have shared separate shared and owner columns.

@skjnldsv
Copy link
Member Author

skjnldsv commented Dec 6, 2023

All good, Marco :)
if the button style must go, then it must go! But without global styling

jancborchardt
jancborchardt requested changes Dec 6, 2023
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have a look with the design team to make sure we keep the previous issue fixed too

Could we make sure that we don’t revert it without addressing that part here already?
The specification / mockup exists at #37208, and as long as design-wise it looks like that, you are expert regarding implementation. :)

@skjnldsv
Copy link
Member Author

skjnldsv commented Dec 6, 2023

Could we make sure that we don’t revert it without addressing that part here already?

image

This was referenced Dec 8, 2023
Merged
Merged
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 28.0.1 Dec 11, 2023
This was referenced Dec 15, 2023
Merged
Merged
Closed
@blizzz blizzz mentioned this pull request Jan 15, 2024
Merged
@blizzz
Copy link
Member

blizzz commented Jan 17, 2024

What about this PR, it appears stale?

@skjnldsv skjnldsv marked this pull request as draft January 18, 2024 11:26
@skjnldsv skjnldsv mentioned this pull request Feb 14, 2024
Merged
8 tasks
@skjnldsv skjnldsv removed this from the Nextcloud 28.0.3 milestone Feb 14, 2024
@emoral435 emoral435 removed their request for review March 4, 2024 16:11
@susnux susnux added this to the Nextcloud 30 milestone Apr 18, 2024
@skjnldsv skjnldsv removed this from the Nextcloud 30 milestone Aug 14, 2024
@skjnldsv skjnldsv closed this Dec 3, 2024
@skjnldsv skjnldsv deleted the revert/41453 branch December 19, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jancborchardt jancborchardt jancborchardt requested changes

@susnux susnux susnux approved these changes

@artonge artonge artonge approved these changes

@Pytal Pytal Pytal approved these changes

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-frontend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-frontend

Assignees

No one assigned

Labels

2. developing Work in progress bug feature: files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@skjnldsv @marcoambrosini @blizzz @jancborchardt @susnux @artonge @Pytal