feat(setupcheck): Add setup check for maintenance_window_start config#42241
Merged
nickvergessen merged 1 commit intomasterfrom Dec 18, 2023
Merged
Conversation
32c71c9 to
367bddd
Compare
marcelklehr
reviewed
Dec 14, 2023
marcelklehr
approved these changes
Dec 14, 2023
come-nc
reviewed
Dec 14, 2023
Contributor
come-nc
left a comment
There was a problem hiding this comment.
nitpick and I agree with @marcelklehr remark, but otherwhise good.
But you will conflict with #41547 #42176 #42177 , wait in line :-P
Signed-off-by: Joas Schilling <[email protected]>
367bddd to
26f4ec6
Compare
Member
Author
Member
Author
|
/backport to stable28 |
come-nc
approved these changes
Dec 18, 2023
Contributor
come-nc
left a comment
There was a problem hiding this comment.
Hum the autoloader and the registration I think, we’ll see.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist