fix(files): Use DAV functions from library to fix invalid source links#42338
Merged
fix(files): Use DAV functions from library to fix invalid source links#42338
Conversation
Contributor
Author
|
/backport to stable28 |
artonge
approved these changes
Dec 18, 2023
Contributor
|
Let's wait for @skjnldsv approval |
skjnldsv
approved these changes
Dec 19, 2023
skjnldsv
reviewed
Dec 19, 2023
| permissions: Permission.READ, | ||
| }), | ||
| contents: contents.map(resultToNode), | ||
| contents: contents.map((r) => davResultToNode(r)), |
Member
There was a problem hiding this comment.
Why not contents: contents.map(davResultToNode) ?
(not a blocker, simply curious))
Contributor
Author
There was a problem hiding this comment.
Parameters do not match map has a signature of element: T, index: number but davResultToNode has element: Result, root?: string as it allows for different root path.
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
83e4d57 to
6556465
Compare
Member
|
/backport 6a67aff to stable28 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor the code to use the files library functions instead which will fix invalid source values causing #4233
Checklist