fix(files): move focus to sidebar on open#42444
Merged
Conversation
8656a08 to
027868e
Compare
027868e to
4ec2ba6
Compare
2 tasks
JuliaKirschenheuter
approved these changes
Feb 7, 2024
Contributor
JuliaKirschenheuter
left a comment
There was a problem hiding this comment.
Works great too! Thank you!
Contributor
|
/compile / |
emoral435
approved these changes
Feb 7, 2024
Contributor
emoral435
left a comment
There was a problem hiding this comment.
Outside of a minor nitpick, LGTM! 🐘💙
Contributor
Author
This PR requires |
608e7d5 to
a70c3de
Compare
skjnldsv
reviewed
Feb 7, 2024
| :close-after-click="!isMenu(action.id)" | ||
| :data-cy-files-list-row-action="action.id" | ||
| :is-menu="isMenu(action.id)" | ||
| :aria-label="mountType === 'shared' && action.id === 'sharing-status' ? action.title([source]) : actionDisplayName(action)" |
Member
There was a problem hiding this comment.
That seems really specific, where is this coming from and what does it have to do with that PR? :)
Contributor
Author
There was a problem hiding this comment.
From the next one line (title prop) and the content of the button 7 lines below. I can move it to a new PR, but a button must have a label or text.
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Contributor
Author
|
/backport to stable28 |
a70c3de to
17c9f73
Compare
Contributor
Author
|
skjnldsv
approved these changes
Feb 8, 2024
Contributor
|
/backport to stable28 |
2 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
See commits for details.
See nextcloud-libraries/nextcloud-vue#5219 for screenshots
Checklist