Fix/files/42460/breadcrumb conditional rendering#42507
Merged
Conversation
Contributor
Author
|
/backport to stable28 |
JuliaKirschenheuter
previously requested changes
Jan 2, 2024
Contributor
JuliaKirschenheuter
left a comment
There was a problem hiding this comment.
good but not completely right
The last item should not have any title, it is just the same item as previous one
5c5c037 to
870827b
Compare
ShGKme
approved these changes
Jan 2, 2024
Contributor
Author
|
Will wait to see what we choose to do going forward before making any more changes :) |
870827b to
287da22
Compare
skjnldsv
approved these changes
Jan 5, 2024
ShGKme
requested changes
Jan 5, 2024
287da22 to
bc2a877
Compare
Contributor
Author
|
Cleaned up the component a bit, I was making it a bit sloppier than it needed to be, to be honest! |
ShGKme
approved these changes
Jan 5, 2024
approved change within messages on Talk :)
Signed-off-by: Eduardo Morales <[email protected]>
bc2a877 to
2554419
Compare
|
The backport to stable28 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b fix/foo-stable28
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable28Error: Unknown error More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
Contributor
Author
|
/ backport 2554419 to stable28 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves #42460
🖼️ Screenshots
🏡 After
🚧 Summary
Removed the title attribute from all breadcrumb headers from all but the first and last breadcrumbs - the first having an aria label, and the last being differently titled than the rest
Checklist