Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove unneeded styles: everything is handled by NcVue#42559

Merged
JuliaKirschenheuter merged 1 commit intomasterfrom
fix/41699-change_styles_for_focused_items_in_sidebar
Jan 5, 2024
Merged

Remove unneeded styles: everything is handled by NcVue#42559
JuliaKirschenheuter merged 1 commit intomasterfrom
fix/41699-change_styles_for_focused_items_in_sidebar

Conversation

@JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter commented Jan 3, 2024 •
edited
Loading

Summary

Vue-navigation Unchanged non-vue navigation
Screenshot from 2024-01-03 15-31-17 Screenshot from 2024-01-03 15-31-12

Checklist

@JuliaKirschenheuter JuliaKirschenheuter added the 3. to review Waiting for reviews label Jan 3, 2024
@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Jan 3, 2024
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/41699-change_styles_for_focused_items_in_sidebar branch from 0921b8b to 024d291 Compare January 3, 2024 15:25
@ShGKme
Copy link
Contributor

ShGKme commented Jan 3, 2024 •
edited by JuliaKirschenheuter
Loading

This PR changes styles for non-@nextcloud-vue navigation while linked PR in nextcloud-vue changes @nextcloud/vue navigation. Are they related?

yes ;(

Peek 2024-01-03 17-06

emoral435
emoral435 approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@emoral435 emoral435 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked this on my dev env and saw that removing this did not cause anything big to stylistically change - it looks good to me.

I do not know if there are any other apps that somehow depend on this, but to my understanding this only lets the elements that are for app navigation within a page have their border color be the primary color. When the changes to the NcAppNavigationItem.scss gets merged, this will be all good 👍

@ShGKme
Copy link
Contributor

ShGKme commented Jan 5, 2024

This PR changes styles for non-@nextcloud-vue navigation while linked PR in nextcloud-vue changes @nextcloud/vue navigation. Are they related?

So, these styles are not supposed to affect @nextcloud/vue/NcAppNavigation. But it does, because the layout of the NcAppNavigation was changed and the selector here is not actual anymore.

So the best could be to fix the selector.

but probably these styles are not actual anymore. Need to check if we still have any non-NcAppNavigation navigation.

@ShGKme
Copy link
Contributor

ShGKme commented Jan 5, 2024 •
edited
Loading

I haven't found non-vue navigation anywhere. Should be safe to remove.

@JuliaKirschenheuter JuliaKirschenheuter merged commit ac10ea4 into master Jan 5, 2024
@JuliaKirschenheuter JuliaKirschenheuter deleted the fix/41699-change_styles_for_focused_items_in_sidebar branch January 5, 2024 16:13
@JuliaKirschenheuter
Copy link
Contributor Author

JuliaKirschenheuter commented Jan 5, 2024

/backport to stable28

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jan 5, 2024
Merged
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pytal Pytal Pytal approved these changes

@ShGKme ShGKme ShGKme approved these changes

@susnux susnux Awaiting requested review from susnux

@szaimen szaimen Awaiting requested review from szaimen

+1 more reviewer

@emoral435 emoral435 emoral435 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JuliaKirschenheuter @ShGKme @Pytal @emoral435