fix(share): use user timezone to parse share expiration date#42660
Merged
fix(share): use user timezone to parse share expiration date#42660
Conversation
Collaborator
Author
|
/backport to stable28 |
5acb08a to
ba5b51f
Compare
ba5b51f to
011d392
Compare
3d2dbd4 to
35c7981
Compare
If an user in UTC+1 try to create a share at 00:00, it's day D for him, but D-1 for the server (UTC). This fix aims to apply the correct offset Signed-off-by: Benjamin Gaussorgues <[email protected]>
35c7981 to
cc3a2c3
Compare
skjnldsv
approved these changes
Jan 9, 2024
come-nc
approved these changes
Jan 15, 2024
nfebe
approved these changes
Jan 15, 2024
Collaborator
Author
|
/backport to stable27 |
Collaborator
Author
|
/backport to stable26 |
Member
|
/skjnldsv-backport to stable26 |
Member
|
/skjnldsv-backport to stable27 |
|
The backport to # Switch to the target branch and update it
git checkout stable26
git pull origin stable26
# Create the new backport branch
git checkout -b backport/42660/stable26
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick cc3a2c351a2db4c30a2f0dc1bde73ba024e88602
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/42660/stable26Error: Validation Failed: {"resource":"PullRequest","code":"custom","message":"No commits between stable26 and backport/42660/stable26"} Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
2 tasks
8 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
If an user in UTC+1 try to create a share at 00:00, it's day D for him, but D-1 for the server (UTC).
This fix aims to apply the correct offset.
Later, it will be better to also handle hours for share expiration.
Checklist