refactor(App): Remove registerRoutes method#42678
Conversation
|
OpenAPI is failing because it previously failed to discover all the routes in user_ldap so they are missing now and need to be documented. |
| use OC\Core\Application; | ||
| /** @var $this OCP\Route\IRouter */ | ||
| // Core ajax actions | ||
| $this->create('core_ajax_update', '/core/ajax/update.php') |
Check notice
Code scanning / Psalm
InvalidScope
| /** @var string[] */ | ||
| private $controllerNameCache = []; | ||
|
|
||
| protected $rootUrlApps = [ |
There was a problem hiding this comment.
???
How is this implemented now?
There was a problem hiding this comment.
Check RouteParser, it has exactly the same apps listed and the same logic 🤷♀️. Think someone just copied parts of the implementation which lead to this logic duplication.
Time to migrate the tests over then? |
Yes, but I took a look and I'm not really sure what the tests are trying to achieve. Are they testing that the routes are correctly parsed or are they checking that the routes are added correctly to the Router? |
|
@provokateurin Can you extract the |
|
Done: #49276 |
|
Rewrote the tests. |
aa3ef3b to
20a12a1
Compare
Signed-off-by: provokateurin <[email protected]>
9d05d6a to
d25dc92
Compare
…s to RouteParser Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
d25dc92 to
e4ed062
Compare
|
Cool, can't approve my own PR unfortunately :) |
Summary
Removes the deprecated App::registerRoutes method.
The RouteConfig class is no longer used so I deleted it as well including it's tests.
For some reason much of the implementation was the same as RouteParser, but that one has no tests 🤔.
Checklist