fix(files): combine navigation and files list into single Vue app#43090
Merged
JuliaKirschenheuter merged 2 commits intomasterfrom Jan 25, 2024
Merged
fix(files): combine navigation and files list into single Vue app#43090JuliaKirschenheuter merged 2 commits intomasterfrom
JuliaKirschenheuter merged 2 commits intomasterfrom
Conversation
2806fb0 to
3840a99
Compare
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
3840a99 to
aa18769
Compare
skjnldsv
approved these changes
Jan 25, 2024
artonge
approved these changes
Jan 25, 2024
JuliaKirschenheuter
approved these changes
Jan 25, 2024
Contributor
JuliaKirschenheuter
left a comment
There was a problem hiding this comment.
works great, thank you!
Contributor
|
/backport b40279e to stable28 |
1 task
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainlandmark on files page #43085Summary
During
files2vuemigration, files were migrated as two Vue apps:<NcAppNavitation><NcAppContent>But Vue app in Nextcloud is supposed to be one NcContent app that contains navigation and content.
After migration has finished there is no need to separate Navigation and FilesList.
TODO
Screenshots
No visual changes on both user files and public share
Checklist