fix: added a label element to the NcSelect in update settings#43094
fix: added a label element to the NcSelect in update settings#43094
Conversation
|
Will /backport once accepted by reviews :) |
|
/compile amend/ |
I think we can make it plain text. It looks inconsistent now, not sure it was needed to be h4 with h4 styles. cc @szaimen |
2d305e6 to
725ee59
Compare
|
@Pytal Fixed! And styling should be the same - had to add high order specifiers with ID's and whatnot because Vue's default styling on their Select component was beating out most things I tried. This kept it pretty consistent: |
|
I'd say we should to drop the custom select__label styles and set @nextcloud/designers for design input |
725ee59 to
914d0b0
Compare
Honestly from design perspective I'd say this detail doesnt really matter as there are many other things on this page that don't look visually perfect 😅🙈 |
914d0b0 to
9148573
Compare
|
/compile amend |
|
/backport to stable28 |
Signed-off-by: Eduardo Morales <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
9148573 to
35518bc
Compare



Summary
@JuliaKirschenheuter (all credit to her) found that in
index.php/settings/admin/overview, there is a NcSelect without a corresponding label. This fixes that, No visual change, gave the label input the corresponding styles that would accompany the change from h4 element 👍TODO
Checklist