fix(sharing): migrate QuickShareSelect to NcActions#43213
Merged
Conversation
susnux
approved these changes
Jan 30, 2024
JuliaKirschenheuter
approved these changes
Jan 30, 2024
Contributor
JuliaKirschenheuter
left a comment
There was a problem hiding this comment.
😍 works great!
Contributor
Author
|
Waiting for |
emoral435
approved these changes
Feb 7, 2024
Contributor
emoral435
left a comment
There was a problem hiding this comment.
LGTM 👍 Tested with NcVue 8.6.1 and works perfectly :)
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
4c4bb24 to
98d9fb1
Compare
Contributor
Author
|
Rebased onto master after upgrading |
Contributor
Author
|
/backport to stable28 |
Contributor
Author
|
/backport 66ba4c1 to stable28 |
1 task
artonge
pushed a commit
that referenced
this pull request
Feb 8, 2024
…uick-share-select-to-nc-actions fix(sharing): migrate QuickShareSelect to NcActions
4 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@nextcloud/[email protected]Summary
The current custom quick share select implementation has a number of a11y issues:
aria-expanded="false"aria-selectedonly ontrue, which is not allowed here and should hasfalsevalueHaving all of that, it seems that moving to
NcActionswithmenu+menuitemradiosemantics and some custom styles for the trigger is the best and easiest way to fix all a11y issues.Screenshots
Checklist