[stable28] feature(files): Hide breadcrumbs when an upload is ongoing on narrow screen #40942#43834
Merged
[stable28] feature(files): Hide breadcrumbs when an upload is ongoing on narrow screen #40942#43834
Conversation
Merged
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Andrii Rublov <[email protected]>
Member
|
Rebasing.... ⌛ |
83381cd to
59cfded
Compare
skjnldsv
approved these changes
Apr 4, 2024
Signed-off-by: Eduardo Morales <[email protected]>
59cfded to
e22b67d
Compare
4 tasks
susnux
reviewed
Apr 4, 2024
|
|
||
| const fileId = this.getFileIdFromPath(path) | ||
| const node = this.getNodeFromId(fileId) | ||
| const fileId: number | undefined = this.getFileIdFromPath(path) |
Contributor
There was a problem hiding this comment.
I do not get why hard coding this is needed instead of implicit type from function return?
Member
There was a problem hiding this comment.
I have no idea 😅
I don't recall when I added this. Might have had a brain Zapp 🙃
susnux
approved these changes
Apr 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #43325
Backport of #44162
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.