Merged
Conversation
Contributor
Author
|
/backport! to stable28 |
Contributor
Author
|
/backport! to stable27 |
2 tasks
Contributor
Author
|
(I’m backporting first, I will fix conflicts after because the conflict is only for master branch) |
Contributor
Author
|
/backport! to stable26 |
Contributor
Author
|
/backport! to stable25 |
Contributor
Author
|
/backport! to stable24 |
Contributor
Author
|
/backport! to stable23 |
2 tasks
2 tasks
|
The backport to # Switch to the target branch and update it
git checkout stable23
git pull origin stable23
# Create the new backport branch
git checkout -b backport/44297/stable23
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 31cd2160 06b5919e
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/44297/stable23Error: Failed to push branch backport/44297/stable23: fatal: could not read Username for 'https://github.com': No such device or address Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
2 tasks
Contributor
Author
This was referenced Mar 19, 2024
Merged
This was referenced Mar 19, 2024
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Contributor
Author
|
Rebased on master and fixed conflicts. Replaced the function content to more modern code to match the other function. |
06b5919 to
c1b451e
Compare
| $groupManager, | ||
| $entityExistsFunction | ||
| $entityExistsFunction, | ||
| fn ($name) => true, |
Check notice
Code scanning / Psalm
MissingClosureParamType
artonge
approved these changes
Mar 19, 2024
Merged
nickvergessen
approved these changes
Mar 21, 2024
artonge
added a commit
that referenced
this pull request
Mar 21, 2024
…files Forbid tagging readonly files Signed-off-by: Louis Chemineau <[email protected]>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Forbid tagging a readonly file.
For other types that may be supported by systemtags if provided by an application (I do not know of any application actually using that feature), update is always allowed for now.
This should be followed by a PR to give a way for applications to provide a writeaccess function as well, for completeness sake.
Checklist