fix(files): also trigger new tab on file name middle click#45571
fix(files): also trigger new tab on file name middle click#45571
Conversation
|
/backport to stable29 |
|
/backport to stable28 |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
|
Ah, no! Now I do remember! If we want to remove the default click-to-download behaviour is a different topic in itself @ShGKme :) |
|
Alright, I tested on safari and it works!
So leaving them both is the way 👍 |
szaimen
left a comment
There was a problem hiding this comment.
Just tested in a Chromium based browser on Windows and seems to work :)
There was a problem hiding this comment.
Tested on Safari 16 and Safari 17, both testing cloud and real MacBook.
Although MDN and caniuse say this event is not supported on Safari completely, it works fine on both list and grid with the middle button click.
But @click.middle would avoid the need to check event.button 👀
|
/compile rebase-amend / |
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
ffd0c9d to
a094ac0
Compare
|
I think this also make the right-click trigger the default action |
Fix #44994