fix: Fix copying to the root of another mountpoint#49895
Merged
Conversation
mejo-
approved these changes
Dec 17, 2024
icewind1991
approved these changes
Dec 17, 2024
Signed-off-by: Côme Chilliet <[email protected]>
826b89b to
08c7001
Compare
Merged
Member
|
/backport to stable30 |
Member
|
/backport to stable29 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We may want to add a method for this as we have the same call to dirname with special handling of
.in a lot of places.But it brings a lot of questions, where to put the method, what to do with
'/', and so on, so for now fixing it the known problem first.Checklist