[stable30] enh: Fix display default expire date, add tests & tiny refactors#50694
Merged
AndyScherzinger merged 5 commits intostable30from Feb 6, 2025
Merged
[stable30] enh: Fix display default expire date, add tests & tiny refactors#50694AndyScherzinger merged 5 commits intostable30from
AndyScherzinger merged 5 commits intostable30from
Conversation
nfebe
reviewed
Feb 6, 2025
Contributor
nfebe
left a comment
There was a problem hiding this comment.
Only some commits here can be backported, some changes are for the sidebar split which only starts from 31
4d4c817 to
c9e545b
Compare
nfebe
approved these changes
Feb 6, 2025
Contributor
|
/compile |
skjnldsv
approved these changes
Feb 6, 2025
artonge
approved these changes
Feb 6, 2025
AndyScherzinger
approved these changes
Feb 6, 2025
Member
|
@nfebe red CI check seems valid |
Signed-off-by: nfebe <[email protected]>
Since `ShareEntryLink` component is used to both create and display/list the share links, we should only set default expiration date on `share.expireDate` when we know is a new share. Otherwise, we overidding data from the backend. Signed-off-by: nfebe <[email protected]>
…reate share Signed-off-by: nfebe <[email protected]>
Signed-off-by: nfebe <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
76bcac9 to
baafbc4
Compare
Contributor
Indeed. I am not sure why the linting for master and 31 fails here (have not checked) but it should be fine now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #50655
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.