Conversation
9 tasks
Member
Author
|
/backport to stable31 |
Member
Author
|
/backport to stable30 |
Member
Author
|
/backport to stable29 |
come-nc
approved these changes
Feb 24, 2025
4 tasks
bd81ef7 to
9714d53
Compare
kyteinsky
reviewed
Feb 25, 2025
Contributor
kyteinsky
left a comment
There was a problem hiding this comment.
thanks for the nice work!
a small related issue is that users added back/freshly added to the target remote share group do not have gain access to the share. Maybe we can throw in a user-added event here too?
Member
Author
|
Will add a behat test for the event listeners to ensure it works and doesn't break again. |
Member
Author
I noticed this as well, can you open an issue about it? I'm not sure how much work it will be and I don't think it's small enough to get it done in this PR. |
Contributor
|
sounds good |
8 tasks
Signed-off-by: provokateurin <[email protected]>
…re providers Signed-off-by: provokateurin <[email protected]>
…eleted or users removed from a group Signed-off-by: provokateurin <[email protected]>
9714d53 to
f5b5aec
Compare
This was referenced Mar 3, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #35159
Fixes #50289
Summary
Checklist