fix(files_reminders): Lower disabled notifications app error to info#51760
fix(files_reminders): Lower disabled notifications app error to info#51760
Conversation
|
/backport to stable31 |
|
/backport to stable30 |
|
/backport to stable29 |
|
/backport to stable28 |
apps/files_reminders/lib/Listener/LoadAdditionalScriptsListener.php
Outdated
Show resolved
Hide resolved
d5c79a5 to
9e13e38
Compare
come-nc
left a comment
There was a problem hiding this comment.
But does files_reminders app make sense if notifications is disabled?
|
This would re-open #49231 as by default info messages are not shown. Why does cypress server enabled files_reminder without enabling notifications first? |
I am not sure, but probably not, hence the request for an error. |
Signed-off-by: Louis Chemineau <[email protected]>
9e13e38 to
04d4945
Compare
Then either clone notifications or disable files_reminder? |
I think that server should not spam the logs when running without external applications. I removed the log and added a setup check, it makes more sense. |
224720f to
67d339c
Compare
Signed-off-by: Louis Chemineau <[email protected]>
67d339c to
776c103
Compare
come-nc
left a comment
There was a problem hiding this comment.
Ok, why not.
Quite frankly I would be for adding a basic dependency system between apps. Nothing fancy, only preventing enabling if dep is not there, and prevent disabling if app is depended upon.
| } | ||
|
|
||
| public function getName(): string { | ||
| return $this->l10n->t('Files reminder'); |
There was a problem hiding this comment.
l10n not injected in constructor
|
|
||
| $context->registerEventListener(LoadAdditionalScriptsEvent::class, LoadAdditionalScriptsListener::class); | ||
|
|
||
| $context->registerSetupCheck(NeedNotificationsApp::class); |
This is spamming the cypress server logs.
Original: #49232
Or should we write a setup check instead?