fix: Proper order for checking path prefix for getting file by id from cache#52008
Merged
icewind1991 merged 2 commits intomasterfrom Apr 8, 2025
Merged
fix: Proper order for checking path prefix for getting file by id from cache#52008icewind1991 merged 2 commits intomasterfrom
icewind1991 merged 2 commits intomasterfrom
Conversation
…m cache Signed-off-by: Julius Knorr <[email protected]>
icewind1991
approved these changes
Apr 7, 2025
Signed-off-by: Julius Knorr <[email protected]>
Member
|
/backport to stable31 |
Member
|
/backport to stable30 |
This was referenced Apr 8, 2025
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise we never end up in the code path to return the cache hit. Seems the order was wrong by accident as we should check if the cache hit path is within the requested path passed as an argument.