[stable31] fix: more optimized caching for share target verification#52071
Open
backportbot[bot] wants to merge 2 commits intostable31from
Open
[stable31] fix: more optimized caching for share target verification#52071backportbot[bot] wants to merge 2 commits intostable31from
backportbot[bot] wants to merge 2 commits intostable31from
Conversation
Signed-off-by: Robin Appelman <[email protected]>
2d40b6d to
d125e81
Compare
nickvergessen
requested changes
Apr 11, 2025
Member
nickvergessen
left a comment
There was a problem hiding this comment.
Has errors and reduces cache hits drastically
provokateurin
previously approved these changes
Apr 11, 2025
PR breaks prod, so invalidating any review
Signed-off-by: Robin Appelman <[email protected]>
Member
|
added #52128 which should un-break things |
Member
|
CI is now all greens, so merge or still blocked? |
Member
|
Should test it on our instance again before? |
Member
Yes, that be best ( if we can do that 👍 ) |
Member
What to do with this PR @icewind1991 @nickvergessen |
Member
|
This patch significantly worsens the performance on our instance causing a much higher load (2-5x times) |
This was referenced Oct 21, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #52045
Warning, This backport's changes differ from the original and might be incomplete⚠️ Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.