Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(security): add configurable IPv6 subnet for BFP and throttling#52223

Merged
provokateurin merged 1 commit intomasterfrom
feat/add-configurable-ipv6-subnet
Apr 17, 2025
Merged

feat(security): add configurable IPv6 subnet for BFP and throttling#52223
provokateurin merged 1 commit intomasterfrom
feat/add-configurable-ipv6-subnet

Conversation

@Altahrim
Copy link
Collaborator

@Altahrim Altahrim commented Apr 16, 2025 •
edited
Loading

Summary

Allows to configure subnet size for IPv6 normalization and use smaller default.

Checklist

@Altahrim Altahrim self-assigned this Apr 16, 2025
@Altahrim Altahrim requested a review from a team as a code owner April 16, 2025 14:11
@Altahrim Altahrim requested review from artonge, nfebe and provokateurin and removed request for a team April 16, 2025 14:11
@Altahrim Altahrim added this to the Nextcloud 32 milestone Apr 16, 2025
@Altahrim Altahrim added the 3. to review Waiting for reviews label Apr 16, 2025
nickvergessen
nickvergessen reviewed Apr 16, 2025
View reviewed changes
@Altahrim Altahrim force-pushed the feat/add-configurable-ipv6-subnet branch from 2e0995d to 446d04e Compare April 16, 2025 14:15
@Altahrim Altahrim force-pushed the feat/add-configurable-ipv6-subnet branch 2 times, most recently from be45f79 to 4276176 Compare April 16, 2025 14:27
@Altahrim
Copy link
Collaborator Author

Altahrim commented Apr 16, 2025

/backport to stable31

@Altahrim
Copy link
Collaborator Author

Altahrim commented Apr 16, 2025

/backport to stable30

@Altahrim
Copy link
Collaborator Author

Altahrim commented Apr 16, 2025

/backport to stable29

@Altahrim Altahrim mentioned this pull request Apr 16, 2025
Merged
4 tasks
provokateurin
provokateurin reviewed Apr 16, 2025
View reviewed changes
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just the comment needs adjustment

@Altahrim Altahrim force-pushed the feat/add-configurable-ipv6-subnet branch from 4276176 to 9f666c2 Compare April 17, 2025 06:12
@provokateurin provokateurin enabled auto-merge April 17, 2025 07:02
@provokateurin provokateurin merged commit f0154a7 into master Apr 17, 2025
191 of 195 checks passed
@provokateurin provokateurin deleted the feat/add-configurable-ipv6-subnet branch April 17, 2025 07:03
This was referenced Apr 17, 2025
Merged
Merged
Merged
@come-nc
Copy link
Contributor

come-nc commented Apr 22, 2025

This broke on 32bit: https://github.com/nextcloud/server/actions/runs/14584944718/job/40908705961

There were 4 errors:

1) Test\Security\Normalizer\IpAddressTest::testGetSubnet with data set #5 ('2001:0db8:0000:0000:0000:8a2e...0:7334', '2001:db8::/56')
ValueError: 64-bit format codes are not available for 32-bit versions of PHP

/__w/server/server/lib/private/Security/Normalizer/IpAddress.php:44
/__w/server/server/lib/private/Security/Normalizer/IpAddress.php:85
/__w/server/server/tests/lib/Security/Normalizer/IpAddressTest.php:64

2) Test\Security\Normalizer\IpAddressTest::testGetSubnet with data set #6 ('2001:db8:3333:4444:5555:6666:7777:8888', '2001:db8:3333:4400::/56')
ValueError: 64-bit format codes are not available for 32-bit versions of PHP

/__w/server/server/lib/private/Security/Normalizer/IpAddress.php:44
/__w/server/server/lib/private/Security/Normalizer/IpAddress.php:85
/__w/server/server/tests/lib/Security/Normalizer/IpAddressTest.php:64

3) Test\Security\Normalizer\IpAddressTest::testGetSubnet with data set #7 ('::1234:5678', '::/56')
ValueError: 64-bit format codes are not available for 32-bit versions of PHP

/__w/server/server/lib/private/Security/Normalizer/IpAddress.php:44
/__w/server/server/lib/private/Security/Normalizer/IpAddress.php:85
/__w/server/server/tests/lib/Security/Normalizer/IpAddressTest.php:64

4) Test\Security\Normalizer\IpAddressTest::testGetSubnet with data set #8 ('[::1]', '::/56')
ValueError: 64-bit format codes are not available for 32-bit versions of PHP

/__w/server/server/lib/private/Security/Normalizer/IpAddress.php:44
/__w/server/server/lib/private/Security/Normalizer/IpAddress.php:85
/__w/server/server/tests/lib/Security/Normalizer/IpAddressTest.php:64

I suppose those tests can simply be skipped on 32bits?
@Altahrim

@susnux susnux mentioned this pull request Apr 23, 2025
Merged
4 tasks
@susnux
Copy link
Contributor

susnux commented Apr 23, 2025

Fix in #52392

P cannot be used on 32bit you need to use VV (possible as we set it to 0 anyways).

@enjeck enjeck mentioned this pull request May 28, 2025
Open
@nextcloud-bot nextcloud-bot mentioned this pull request Aug 19, 2025
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@provokateurin provokateurin provokateurin approved these changes

@artonge artonge Awaiting requested review from artonge artonge is a code owner automatically assigned from nextcloud/server-backend

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-backend

Assignees

@Altahrim Altahrim

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

6 participants

@Altahrim @come-nc @susnux @nickvergessen @provokateurin @skjnldsv