Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(previews): Allow to parse big files for previews#53496

Closed
solracsf wants to merge 1 commit intomasterfrom
fullFilePreviews
Closed

fix(previews): Allow to parse big files for previews#53496
solracsf wants to merge 1 commit intomasterfrom
fullFilePreviews

Conversation

@solracsf
Copy link
Member

@solracsf solracsf commented Jun 14, 2025 •
edited
Loading

Checklist

@solracsf
Copy link
Member Author

solracsf commented Jun 14, 2025

/backport to stable31

@solracsf solracsf added this to the Nextcloud 32 milestone Jun 14, 2025
@solracsf solracsf marked this pull request as ready for review June 14, 2025 13:53
@solracsf solracsf requested a review from a team as a code owner June 14, 2025 13:53
@solracsf solracsf requested review from artonge, come-nc, icewind1991, leftybournes, printminion-co, skjnldsv and yemkareems and removed request for a team June 14, 2025 13:53
@come-nc
Copy link
Contributor

come-nc commented Jun 16, 2025

It feels weird to have this as a general option in config.php.

It should be an option for each storage defined in files_external, no? You may want to enable it for an SMB one on local network and disable it for another s3 storage? Or is that too niche?

@icewind1991
Copy link
Member

icewind1991 commented Jun 16, 2025

I agree that having this per storage would be better.

Additionally, allowing the admin to set a different cutoff size instead of just disabling the cutoff altogether would be nice.

Note that there is a "mount options" system that would probably make sense to use to configure this.

They can be set with occ files_external:option <mount id> <key> <value> and then checked with $file->getMountPoint()->getOption($key, $default)

@solracsf
Copy link
Member Author

solracsf commented Jun 16, 2025

Got it. 👍
In that case, i'm closing here in favour of a "per storage" option.

@solracsf solracsf closed this Jun 16, 2025
@skjnldsv skjnldsv deleted the fullFilePreviews branch June 16, 2025 17:14
@solracsf solracsf mentioned this pull request Jun 17, 2025
Closed
8 tasks
@invario invario mentioned this pull request Jul 16, 2025
Merged
6 tasks
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner automatically assigned from nextcloud/server-backend

@yemkareems yemkareems Awaiting requested review from yemkareems yemkareems is a code owner automatically assigned from nextcloud/server-backend

@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend

@artonge artonge Awaiting requested review from artonge

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@come-nc come-nc Awaiting requested review from come-nc

@printminion-co printminion-co Awaiting requested review from printminion-co

Assignees

No one assigned

Labels

3. to review Waiting for reviews backport-request feature: previews and thumbnails regression

Projects

None yet

Milestone

Nextcloud 33

Development

Successfully merging this pull request may close these issues.

[Bug]: Movie preview not generated on remote storages if file > 5MiB

4 participants

@solracsf @come-nc @icewind1991 @skjnldsv