fix(imip): set charset for imip attachment#53814
Conversation
|
cc @ChristophWurst, could you do a smoke test with evolution? |
ChristophWurst
left a comment
There was a problem hiding this comment.
The invites you have forwarded are processed correctly by Evolution 👍
9c5f7a0 to
f807249
Compare
Signed-off-by: Daniel Kesselberg <[email protected]>
Signed-off-by: Daniel Kesselberg <[email protected]>
f807249 to
4dee178
Compare
|
Hi, I wanted a test to ensure we are not losing that requirement for charset=utf-8 in a future change, as it’s a detail that’s easy to miss. The IMipPlugin sends emails for iTIP messages (e.g. calendar invitations or updates). That involves a couple of dependencies needed to get the job done. It’s therefore no surprise that our unit tests for IMipPlugin make heavy use of test doubles. I often find it hard to find out the actual purpose of a test because the majority of the test code is mocking dependencies. Therefore, I opted not to add another test to IMipPluginTest but to start from scratch. While it’s currently inevitable to use mocks, I at least want to avoid mocking the “core components” IMipPlugin, IMipService, and EventComparisonService, as they are tightly coupled anyway. IMipPluginCharsetTest still makes heavy use of test doubles, but it's hopefully a bit easier to understand and has a clearer scope. |
|
Re-requested a review, because of new test. |
|
/backport to stable31 |
|
/backport to stable30 |
Summary
TODO
Checklist