feat: automated appointment creation#56924
Merged
SebastianKrupinski merged 1 commit intomasterfrom Jan 15, 2026
Merged
Conversation
8f9bd94 to
b6f9404
Compare
b6f9404 to
e98decb
Compare
Contributor
Author
|
@ChristophWurst @kesselb @DerDreschner review please |
DerDreschner
approved these changes
Jan 14, 2026
kesselb
reviewed
Jan 14, 2026
Merged
Contributor
Author
|
@ChristophWurst @kesselb @hamza221 review please |
ChristophWurst
approved these changes
Jan 15, 2026
f434863 to
0da2066
Compare
kesselb
requested changes
Jan 15, 2026
Contributor
kesselb
left a comment
There was a problem hiding this comment.
Array shape needs an update; otherwise it won't match what's implemented in nextcloud/mail#12144.
lib/public/Calendar/IManager.php
Outdated
| * Handles a iMip message | ||
| * | ||
| * @param array{absent?: "create", recipient?: string} $options | ||
| * @param array{absent?: "create", absentCreateStatus?: string, recipient?: string} $options |
Contributor
There was a problem hiding this comment.
Suggested change
| * @param array{absent?: "create", absentCreateStatus?: string, recipient?: string} $options | |
| * @param array{absent?: "create"|"ignore", absentCreateStatus?: "cancelled"|"confirmed"|"tentative", recipient?: string, ...} $options |
... tell Psalm to be a bit more relaxed about additional fields in the future ;)
Contributor
Author
There was a problem hiding this comment.
Sure. Done
Signed-off-by: SebastianKrupinski <[email protected]>
0da2066 to
16198d2
Compare
kesselb
approved these changes
Jan 15, 2026
Member
@SebastianKrupinski that checkbox is already ticket while there is no developer documentation for the public API change as far as I can see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
3. to review, feature component)stable32)