Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[stable33] getById: don't setup for all users with access by default#58000

Merged
AndyScherzinger merged 3 commits intostable33from
setup-root-path-children-less-setup-33
Feb 3, 2026
Merged

[stable33] getById: don't setup for all users with access by default#58000
AndyScherzinger merged 3 commits intostable33from
setup-root-path-children-less-setup-33

Conversation

@icewind1991
Copy link
Member

Partly reverts the behavior of #57913 to use the already-setup mounts.

Only when no already setup mounts are found, do we perform extra setups, and then only for the relevant user (if a user is available)

Extracted from #57910

@icewind1991 icewind1991 added this to the Nextcloud 33 milestone Feb 2, 2026
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Feb 2, 2026
@icewind1991 icewind1991 requested a review from a team as a code owner February 2, 2026 14:26
@icewind1991 icewind1991 requested review from ArtificialOwl, CarlSchwan, leftybournes and salmart-dev and removed request for a team February 2, 2026 14:26
@icewind1991 icewind1991 force-pushed the setup-root-path-children-less-setup-33 branch from 739c9b1 to f68894f Compare February 2, 2026 15:25
@nickvergessen
Copy link
Member

 
1) Test\Files\ViewTest::testGetPathNotExisting
Failed asserting that exception of type "Error" matches expected exception "OCP\Files\NotFoundException". Message was: "Call to a member function getUID() on null" at
/home/runner/actions-runner/_work/server/server/lib/private/Files/Node/Root.php:448
/home/runner/actions-runner/_work/server/server/lib/private/Files/Node/Root.php:393
/home/runner/actions-runner/_work/server/server/lib/private/Files/Node/LazyFolder.php:65
/home/runner/actions-runner/_work/server/server/lib/private/Files/Node/LazyRoot.php:46
/home/runner/actions-runner/_work/server/server/lib/private/Files/View.php:1831
/home/runner/actions-runner/_work/server/server/tests/lib/Files/ViewTest.php:302

@icewind1991 icewind1991 force-pushed the setup-root-path-children-less-setup-33 branch from f3de2b3 to 0496d13 Compare February 2, 2026 18:01
Signed-off-by: Robin Appelman <[email protected]>
@AndyScherzinger AndyScherzinger merged commit baff429 into stable33 Feb 3, 2026
210 of 243 checks passed
@AndyScherzinger AndyScherzinger deleted the setup-root-path-children-less-setup-33 branch February 3, 2026 19:43
@provokateurin
Copy link
Member

/backport to master

@backportbot
Copy link

backportbot bot commented Feb 5, 2026

The backport to master failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout master
git pull origin master

# Create the new backport branch
git checkout -b backport/58000/master

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick f55afafc 0496d133 34448dd1

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/58000/master

Error: Failed to check for changes with origin/master: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants