Open
Conversation
Signed-off-by: GitHub <[email protected]>
CarlSchwan
approved these changes
Mar 1, 2026
1830de9 to
671cec3
Compare
Signed-off-by: Carl Schwan <[email protected]>
671cec3 to
4588c71
Compare
come-nc
reviewed
Mar 2, 2026
Comment on lines
-206
to
+226
| } catch (Exception $e) { | ||
| } catch (DBException $e) { | ||
| $this->logger->warning('issue while deleteMetadata', ['exception' => $e, 'fileId' => $fileId]); | ||
| } | ||
|
|
||
| try { | ||
| $this->indexRequestService->dropIndex($fileId); | ||
| } catch (Exception $e) { | ||
| } catch (DBException $e) { | ||
| $this->logger->warning('issue while deleteMetadata', ['exception' => $e, 'fileId' => $fileId]); | ||
| } | ||
| } | ||
|
|
||
| public function deleteMetadataForFiles(int $storage, array $fileIds): void { | ||
| try { | ||
| $this->metadataRequestService->dropMetadataForFiles($storage, $fileIds); | ||
| } catch (Exception $e) { | ||
| } catch (DBException $e) { | ||
| $this->logger->warning('issue while deleteMetadata', ['exception' => $e, 'fileIds' => $fileIds]); | ||
| } | ||
|
|
||
| try { | ||
| $this->indexRequestService->dropIndexForFiles($fileIds); | ||
| } catch (Exception $e) { | ||
| } catch (DBException $e) { |
Member
There was a problem hiding this comment.
Good question, rector doing rector thing :/
Comment on lines
-142
to
144
| /** | ||
| * @param string $storageId | ||
| * @return \OC\Files\Mount\MountPoint[] | ||
| */ | ||
| public function getMountByStorageId($storageId) { | ||
| return $this->mountManager->findByStorageId($storageId); | ||
| } | ||
|
|
||
| /** | ||
| * @param int $numericId | ||
| * @return MountPoint[] | ||
| */ | ||
| public function getMountByNumericStorageId($numericId) { | ||
| return $this->mountManager->findByNumericId($numericId); | ||
| } | ||
|
|
||
| /** | ||
| * @param \OC\Files\Mount\MountPoint $mount | ||
| */ | ||
| public function unMount($mount) { | ||
| $this->mountManager->remove($mount); | ||
| } | ||
|
|
||
| public function get($path) { |
Member
There was a problem hiding this comment.
Dead code which is completely broken. E.g mount manager doesn't have a remove method.
Since psalm was suddenly complaining about it, i decided to just remove it since it was unused
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated changes by create-pull-request GitHub action