perf(encryption): use unset unused unencrypted filesize cache - #64287
Open
susnux wants to merge 1 commit into
Open
perf(encryption): use unset unused unencrypted filesize cache#64287susnux wants to merge 1 commit into
susnux wants to merge 1 commit into
Conversation
We need to keep unencrypted filesize inmemory because: - A fresh upload has no cache row at `stream_close` time. The entry is consumed later by `getMetaData` during the post-write scan and `modifyMetaData` so until the caller persisted it we need to keep in in cache - Part files have no cache row at all, their entry must survive until the `rename` to the final path. So for huge operations like moving / copying whole folder trees this cache would otherwise grow infinite large. Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Ferdinand Thiessen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We need to keep unencrypted filesize inmemory because:
stream_closetime. The entry is consumed later bygetMetaDataduring the post-write scan andmodifyMetaDataso until the caller persisted it we need to keep in in cacherenameto the final path.So for huge operations like moving / copying whole folder trees this cache would otherwise grow infinite large.
Checklist
3. to review, feature component)stable32)AI (if applicable)
Claude used to generate unit tests.