Allow pasting an image from the clipboard#2265
Merged
julien-nc merged 1 commit intoenh/image-drag-n-dropfrom Mar 31, 2022
Merged
Allow pasting an image from the clipboard#2265julien-nc merged 1 commit intoenh/image-drag-n-dropfrom
julien-nc merged 1 commit intoenh/image-drag-n-dropfrom
Conversation
Member
Author
|
/compile amend |
59cd523 to
a59f290
Compare
7ff67b6 to
6f619c0
Compare
vinicius73
approved these changes
Mar 31, 2022
Signed-off-by: Julien Veyssier <[email protected]>
a59f290 to
3396ec2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's include that in the image drag'n'drop #2264
This handles the case in which the paste event also contains some text (like when the image is copied from the EyeOfGnome image viewer). The text is ignored and not pasted.
The logic is to catch the event in the Image prosemirror plugin, prevent it and dispatch a bubbled custom one for the editor wrapper which performs the upload.
This could alternatively be done anywhere else, in any other Node, we could extend the Text one for example.