Allow opening files outside of the file system in viewer#2832
Merged
juliusknorr merged 4 commits intomainfrom Aug 7, 2023
Merged
Allow opening files outside of the file system in viewer#2832juliusknorr merged 4 commits intomainfrom
juliusknorr merged 4 commits intomainfrom
Conversation
3 tasks
This was referenced Aug 24, 2022
This was referenced Sep 6, 2022
This was referenced Sep 20, 2022
33a17b9 to
55797d1
Compare
2 flaky tests on run #11554 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Sync service provider > recovers from a dropped message |
Output
Screenshots
|
|
UsersApi.spec.js • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| The user mention API > fetches users with valid session |
Output
Screenshots
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
17 tasks
55797d1 to
0688318
Compare
Member
Author
|
I've updated the checklist above, when giving it another test run together with the versions PR i think there are a few more topics to address, added to the description. |
878308e to
420d551
Compare
Member
Author
|
@ChristophWurst FYI we will merge and backport this for 27.1. Iirc you had a mimetype filter in mail so might be a quick win to enable preview for markdown attachments then |
max-nextcloud
approved these changes
Aug 7, 2023
Collaborator
max-nextcloud
left a comment
There was a problem hiding this comment.
Just a minor remark. Other than that... good to go from my side.
420d551 to
d91463d
Compare
d91463d to
cba8cfc
Compare
Signed-off-by: Julius Härtl <[email protected]> Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
cba8cfc to
b35a369
Compare
Member
Author
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
Member
|
/backport 246f158,67f01011cd16b62d153a8593bc49fc55b3c10b20,b35a36968cc33270502133fb44d0a187864b7d4e to stable27 |
|
The backport to stable27 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
Merged
9 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some early PoC for displaying text file attachments from mail in viewer
Follow up / separate
cc @ChristophWurst