fix: Limit asset/source loader rule to inline svg embeddings from @mdi/svg#4997
Merged
juliusknorr merged 1 commit intomainfrom Nov 13, 2023
Merged
fix: Limit asset/source loader rule to inline svg embeddings from @mdi/svg#4997juliusknorr merged 1 commit intomainfrom
juliusknorr merged 1 commit intomainfrom
Conversation
…i/svg Signed-off-by: Julius Härtl <[email protected]>
8367252 to
6227bbc
Compare
mejo-
approved these changes
Nov 13, 2023
Member
mejo-
left a comment
There was a problem hiding this comment.
While I don't fully understand the logic around webpack raw-loader, webpack rules and loading the FilePlus icon as raw SVG, the PR indeed fixes the issue at hand in my local tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix checkbox icons that were broken due to using the wrong rule: